Merge base into fork #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(ecr): set correct resource policy for ecr repository * Use the full ARN of the repository in the ECR policy This fixes the aws-ecr-assets test where an IAM user receives the policy instead of the ECR repository. * Remove resource statement when resource policy is changed
* Add additional missing unit tests * Update on aug 19 feedbacks * Indentations and minor change
BREAKING CHANGE: Java builders no longer use the "with" prefix.
Also add checks to verify that <clause> and <notClause> cannot be used together, as per [0]. [0]: https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_grammar.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license